Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require valid passport when setting GitHub username #71

Merged
merged 17 commits into from
Oct 22, 2023
Merged

Require valid passport when setting GitHub username #71

merged 17 commits into from
Oct 22, 2023

Conversation

aahna-ashina
Copy link
Member

@aahna-ashina aahna-ashina commented Sep 27, 2023 •
edited
Loading

Require valid (not expired) passport when registering for NationCred.

Dework Task

Related GitHub Issue

#70

How Has This Been Tested?

  • Status checks pass
  • Works on Goerli
  • Works on Mainnet

Are There Admin Tasks?

@aahna-ashina aahna-ashina requested a review from a team September 27, 2023 12:59
@aahna-ashina aahna-ashina self-assigned this Sep 27, 2023
@aahna-ashina aahna-ashina changed the title Active passport GitHub Require active passport when setting GitHub username Sep 27, 2023
yahiamarzouk
yahiamarzouk previously approved these changes Sep 27, 2023
View reviewed changes
@aahna-ashina aahna-ashina changed the title Require active passport when setting GitHub username Require valid passport when setting GitHub username Sep 29, 2023
@aahna-ashina aahna-ashina requested a review from a team October 22, 2023 07:39
yahiamarzouk
yahiamarzouk previously approved these changes Oct 22, 2023
View reviewed changes
Copy link

@yahiamarzouk yahiamarzouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the great job working these smart contracts < 3

@aahna-ashina aahna-ashina requested a review from a team October 22, 2023 15:53
@aahna-ashina aahna-ashina mentioned this pull request Oct 22, 2023
Closed
3 tasks
@aahna-ashina aahna-ashina merged commit 4c936f4 into main Oct 22, 2023
6 checks passed
@aahna-ashina aahna-ashina deleted the active-passport-github branch October 22, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yahiamarzouk yahiamarzouk yahiamarzouk left review comments

Assignees

@aahna-ashina aahna-ashina

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aahna-ashina @yahiamarzouk